Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled docker tests, set up travis to run redis #107

Merged
merged 2 commits into from May 15, 2019
Merged

Enabled docker tests, set up travis to run redis #107

merged 2 commits into from May 15, 2019

Conversation

barambani
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #107 into master will increase coverage by 14.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #107       +/-   ##
===========================================
+ Coverage   22.99%   37.23%   +14.24%     
===========================================
  Files          33       33               
  Lines         948      948               
  Branches       17       10        -7     
===========================================
+ Hits          218      353      +135     
+ Misses        730      595      -135
Impacted Files Coverage Δ
core/src/main/scala/laserdisc/protocol/RESP.scala 77.07% <0%> (+2.54%) ⬆️
core/src/main/scala/laserdisc/protocol/Show.scala 87.09% <0%> (+3.22%) ⬆️
core/src/main/scala/laserdisc/package.scala 56.52% <0%> (+4.34%) ⬆️
...re/src/main/scala/laserdisc/protocol/StringP.scala 5.08% <0%> (+5.08%) ⬆️
core/src/main/scala/laserdisc/protocol/Read.scala 49.46% <0%> (+13.97%) ⬆️
core/src/main/scala/laserdisc/protocol/ListP.scala 25% <0%> (+25%) ⬆️
...s2/src/main/scala/laserdisc/fs2/RedisAddress.scala 40% <0%> (+40%) ⬆️
...e/src/main/scala/laserdisc/protocol/Protocol.scala 55.55% <0%> (+55.55%) ⬆️
fs2/src/main/scala/laserdisc/fs2/MkResource.scala 63.63% <0%> (+63.63%) ⬆️
fs2/src/main/scala/laserdisc/fs2/RedisClient.scala 68.57% <0%> (+68.57%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e21a1...9c20540. Read the comment docs.

Copy link
Member

@sirocchj sirocchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@sirocchj sirocchj merged commit 5aae5c8 into laserdisc-io:master May 15, 2019
@barambani barambani deleted the enable-docker-tests branch May 15, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants