Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build environment #170

Closed
wants to merge 15 commits into from
Closed

Update build environment #170

wants to merge 15 commits into from

Conversation

barambani
Copy link
Member

@barambani barambani commented Oct 22, 2019

How about we remove jdk8 from the build ?

@@ -7,7 +7,7 @@ scala:
- 2.13.0

jdk:
- openjdk8
- openjdk11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why not worth adding instead of replacing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, let's say that the reason is Travis. It looks like there is a bit of a mess around the Jdk versions supported by bionic. What I mean is this and this travis-ci/docs-travis-ci-com#2444 .
We are not in a rush on this change so we can wait, and if they decide that they will not support openjdk8 we might think again if we want to add a customization for that to the build. Or we might even consider migrating to Circle CI.

@codecov-io
Copy link

codecov-io commented Oct 23, 2019

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   59.79%   59.79%           
=======================================
  Files          38       38           
  Lines        1291     1291           
  Branches        6        6           
=======================================
  Hits          772      772           
  Misses        519      519

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f3fff7...82b332f. Read the comment docs.

@barambani barambani mentioned this pull request Oct 26, 2019
@barambani
Copy link
Member Author

I would close this, I have the feeling that is not gonna get merged soon. We will track other options in other prs. What do you think ?

@barambani barambani closed this Feb 24, 2020
@barambani barambani deleted the update-build-env branch August 6, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants