New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build environment #170
Conversation
@@ -7,7 +7,7 @@ scala: | |||
- 2.13.0 | |||
|
|||
jdk: | |||
- openjdk8 | |||
- openjdk11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why not worth adding instead of replacing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, let's say that the reason is Travis. It looks like there is a bit of a mess around the Jdk versions supported by bionic
. What I mean is this and this travis-ci/docs-travis-ci-com#2444 .
We are not in a rush on this change so we can wait, and if they decide that they will not support openjdk8
we might think again if we want to add a customization for that to the build. Or we might even consider migrating to Circle CI.
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
=======================================
Coverage 59.79% 59.79%
=======================================
Files 38 38
Lines 1291 1291
Branches 6 6
=======================================
Hits 772 772
Misses 519 519 Continue to review full report at Codecov.
|
I would close this, I have the feeling that is not gonna get merged soon. We will track other options in other prs. What do you think ? |
How about we remove jdk8 from the build ?