Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circe interop module #52

Merged
merged 7 commits into from Nov 6, 2018
Merged

Add circe interop module #52

merged 7 commits into from Nov 6, 2018

Conversation

sirocchj
Copy link
Member

@sirocchj sirocchj commented Nov 5, 2018

No description provided.

@barambani
Copy link
Member

Linking to #47

@sirocchj
Copy link
Member Author

sirocchj commented Nov 5, 2018

I’ve just realised the Read part is incorrect. It should be Read[NonNullBulkString, A]
Also: add tests

barambani
barambani previously approved these changes Nov 5, 2018
@sirocchj sirocchj changed the title Fix 47 Add circe interop module Nov 5, 2018
@sirocchj sirocchj merged commit 6194c89 into laserdisc-io:master Nov 6, 2018
@sirocchj sirocchj deleted the fix-47 branch November 6, 2018 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants