New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circe interop module #52

Merged
merged 7 commits into from Nov 6, 2018

Conversation

Projects
None yet
2 participants
@sirocchj
Member

sirocchj commented Nov 5, 2018

No description provided.

@sirocchj sirocchj requested a review from barambani Nov 5, 2018

@barambani

This comment has been minimized.

Member

barambani commented Nov 5, 2018

Linking to #47

@sirocchj

This comment has been minimized.

Member

sirocchj commented Nov 5, 2018

I’ve just realised the Read part is incorrect. It should be Read[NonNullBulkString, A]
Also: add tests

@sirocchj sirocchj changed the title from Fix 47 to Add circe interop module Nov 5, 2018

sirocchj added some commits Nov 6, 2018

@sirocchj sirocchj merged commit 6194c89 into laserdisc-io:master Nov 6, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sirocchj sirocchj deleted the sirocchj:fix-47 branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment