Support adding additional special tokens #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "docu_text", "docu_json", "sent_text", "sent_json"으로 corpus_type을
정의함.
- 위에 대응하여 load_corpora 함수를 수정함.
- "sent_text"에 대응되는 loading scripts의 이름과 class 명을 수정함
- serialize_corpora.py에서 corpus_type에 대응되게 argument parser를
수정함.
- train_tokenizer.py에서 corpus_type에 대응되게 refactoring을 수행함.
- model_name -> model_type으로 수정함.
Refs: #23
- black을 적용하는 style을 huggingface transformers에 맞춤. - black, isort 재적용 Refs: #23
- additional_special_tokens을 subword tokenizer 학습 시 추가하는 기능 - 기본적으로 사용되는 special_tokens와 중복되지않게함. Refs: #5
monologg
reviewed
Nov 30, 2021
iron-ij
requested changes
Nov 30, 2021
iron-ij
reviewed
Nov 30, 2021
Co-authored-by: Inje Ryu <36367357+iron-ij@users.noreply.github.com>
Co-authored-by: Inje Ryu <36367357+iron-ij@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #5