Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lasso-require version too low #11

Closed
chsea opened this issue Aug 12, 2016 · 1 comment
Closed

Lasso-require version too low #11

chsea opened this issue Aug 12, 2016 · 1 comment

Comments

@chsea
Copy link

chsea commented Aug 12, 2016

Lasso-require is now on version 3.1.3, which includes changes that are required by the eBay homepage team. However, karma-lasso sets lasso-require's version at ^1, giving us a peer dependency error. Can you use >=1 instead?

cc @patrick-steele-idem
@pranavjha pranavjha mentioned this issue Aug 13, 2016
Merged
@pranavjha
Copy link
Contributor

published a new version wit the fix.

pranavjha added a commit that referenced this issue Aug 13, 2016
@pranavjha
Merge pull request #12 from pranavjha/master
af5cb5b 
loosened up versions for lasso and lasso-require, fixes: #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pranavjha @chsea