Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move !readOnly check to entire header grouping at top for all buttons #1032

Merged
merged 2 commits into from
Jan 26, 2024

Commits on Jan 25, 2024

  1. Share button [1/n]: Create button UI

    Doesn't do anything when you click it now, but just setting up the UI and tooltip. Will add upload feature next PR
    
    ## Test Plan
    Run these commands from the `aiconfig` dir:
    ```bash
    aiconfig_path  =./cookbooks/Gradio/huggingface.aiconfig.json
    parsers_path=./cookbooks/Gradio/hf_model_parsers.py
    aiconfig edit --aiconfig-path=$aiconfig_path --server-port=8080 --server-mode=debug_servers --parsers-module-path=$parsers_path
    ```
    
    <img width="1512" alt="Screenshot 2024-01-25 at 15 58 42" src="https://github.com/lastmile-ai/aiconfig/assets/151060367/6f414df7-dcf3-4b58-beed-c4fc3f7c2968">
    Rossdan Craig rossdan@lastmileai.dev committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    c1af901 View commit details
    Browse the repository at this point in the history
  2. Move !readOnly check to entire header grouping at top for all buttons

    Doing this makes it easier to manage rather than gating each one individually
    
    ## Test Plan
    No functional changes
    
    ReadOnly mode
    
    <img width="1512" alt="Screenshot 2024-01-25 at 16 03 30" src="https://github.com/lastmile-ai/aiconfig/assets/151060367/3493b525-e943-46fe-805d-3424af206bae">
    
    
    Regular mode (with share button shown)
    
    <img width="1512" alt="Screenshot 2024-01-25 at 16 04 06" src="https://github.com/lastmile-ai/aiconfig/assets/151060367/fc7a86c2-8efb-4190-afe9-870a15e93f46">
    Rossdan Craig rossdan@lastmileai.dev committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    7a54ca1 View commit details
    Browse the repository at this point in the history