UI For Global Model Settings #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 12, 2024
added 5 commits
March 12, 2024 15:02
# [1/n] Move Global Parameters into ConfigMetadataContainer This PR stack will set up a basic UI for managing global model settings. Up until now, we've had no way to set model settings (such as system prompt) in the global config metadata from within the editor UI. We've had user feedback about this pain-point, and this is also going to be a crucial integration for the eval UI we're working on (since otherwise you would need to manually add different system prompts to all prompts in the config being evaluated, which is a LOT more friction than current state of using a single system prompt variable in python). In this PR: - Refactor Global parameters component into a global ConfigMetadataContainer which itself contains the global parameters component - Subsequent PRs will add global model settings to this container as well ## Testing: - Just ensure global parameters work as normal 
# Update getModels to Make Search String Optional In a few cases, we don't have a search string to use for the getModels call and it's weird to need to pass in an empty string to represent that case. Just updating the implementation to make the search string optional ## Testing: - Make sure all getModels calls work (add prompt, prompt model selector)
# Pull ModelMenuDropdown to its own Component Pulling out the model menu dropdown (searchable list of models) into its own component for reuse. It's currently used in the AddPromptButton but will be used in the global model settings renderer for adding model to set settings for. ## Testing: - Make sure add prompt menu works correctly 
# Move ModelSettingsRenderers into models Folder The ModelMenuDropdown was created within components/models folder, so we can move other model-related components (settings renderers) to this folder as well. These components will be reused in the global model settings renderer so they're not just associated with prompts anymore. ## Testing: - Make sure model settings render correctly for prompts 
# UI For Global Model Settings Add a basic UI for global model settings. Mainly, treat it similar to global parameters, colocating under the accordion component. Reusing the model settings renderer from the prompt side panel here with scroll view and max height:   
rholinshead
requested review from
saqadri,
suyoglastmileai,
Ankush-lastmile,
jonathanlastmileai and
rossdanlm
as code owners
saqadri
approved these changes
Mar 12, 2024
rholinshead
added a commit
that referenced
this pull request
Mar 12, 2024
Support Deleting Global Model Settings # Support Deleting Global Model Settings Add the UI and implementation for deleting global model settings from the config metadata: https://github.com/lastmile-ai/aiconfig/assets/5060851/c39be364-8ea4-4ab7-bd2f-14dab09753bb --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/1444). * __->__ #1444 * #1443 * #1442 * #1441 * #1440 * #1439 * #1438 * #1437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI For Global Model Settings
UI For Global Model Settings
Add a basic UI for global model settings. Mainly, treat it similar to global parameters, colocating under the accordion component. Reusing the model settings renderer from the prompt side panel here with scroll view and max height:
Stack created with Sapling. Best reviewed with ReviewStack.