-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model setting completion params for Image2Text prompt schema #875
Conversation
TSIA, pretty simple actually ## Test Plan Follow the README from AIConfig Editor https://github.com/lastmile-ai/aiconfig/tree/main/python/src/aiconfig/editor#dev, then run these commands: Make sure also that you don't have the `python-aiconfig-test` installed: `pip3 uninstall python-aiconfig-test` ```bash aiconfig_path=/Users/rossdancraig/Projects/aiconfig/cookbooks/Gradio/huggingface.aiconfig.json parsers_path=/Users/rossdancraig/Projects/aiconfig/cookbooks/Gradio/hf_model_parsers.py alias aiconfig="python3 -m 'aiconfig.scripts.aiconfig_cli'" aiconfig edit --aiconfig-path=$aiconfig_path --server-port=8080 --server-mode=debug_servers --parsers-module-path=$parsers_path ``` <img width="1261" alt="Screenshot 2024-01-11 at 01 21 21" src="https://github.com/lastmile-ai/aiconfig/assets/151060367/63ef4830-1163-4229-90ea-d49b914d1ec2">
"audio/webm", | ||
"audio/flac", | ||
"audio/ogg", | ||
"audio/ogg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks duplicated. Error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just auto-formatting when I hit the CMD + S
type: "number", | ||
description: `The maximum numbers of tokens to generate, ignoring the number of tokens in the prompt` | ||
} | ||
type: "integer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because number is a float while integer is an integer value. I think this was incorrectly transcribed the first time
type: "number", | ||
description: `The maximum time in seconds to wait for fetching images | ||
from the web. If None, no timeout is set and the call may block forever.`, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow that's a short list of possible params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea it's actually pretty wild. It's why I left a comment about it in in summary for #855
Add model setting completion params for Image2Text prompt schema
TSIA, pretty simple actually
Test Plan
Follow the README from AIConfig Editor https://github.com/lastmile-ai/aiconfig/tree/main/python/src/aiconfig/editor#dev, then run these commands:
Make sure also that you don't have the
python-aiconfig-test
installed:pip3 uninstall python-aiconfig-test
Stack created with Sapling. Best reviewed with ReviewStack.