Decrease the time for the cli app to do things #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waterkip
force-pushed
the
gh-475-decrease_display_time
branch
from
0e41115
to
52e0f85
Compare
GPaulovics
force-pushed
the
master
branch
2 times, most recently
from
0ec9d7a
to
60d9968
Compare
When the local blob version and the remote version are the same skip downloading a new blob and just continue with the current blob. This could potentially shave 300ms (or more, I've seen close to 2 seconds in my browser) when the blob hasn't been updated on the remote side. There is still a small performance hit on `login_check.php` but I cannot think of logical ways why we would increase the timeout, the 5 seconds that is place now make sense to me as you want to display things. Maybe there should be a post action on any command that has `--sync=auto` so subsequent calls have a blob in sync and would cause slowness of the CLI app. Fixes: lastpass#475 Signed-off-by: Wesley Schwengle <wesley@schwengle.net>
Signed-off-by: Wesley Schwengle <wesley@schwengle.net>
waterkip
force-pushed
the
gh-475-decrease_display_time
branch
from
52e0f85
to
37800a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the local blob version and the remote version are the same skip
downloading a new blob and just continue with the current blob. This
could potentially shave 300ms (or more, I've seen close to 2 seconds in
my browser) when the blob hasn't been updated on the remote side.
There is still a small performance hit on
login_check.phpbut I cannotthink of logical ways why we would increase the timeout, the 5 seconds
that is place now make sense to me as you want to display things. Maybe
there should be a post action on any command that has
--sync=autososubsequent calls have a blob in sync and would cause slowness of the CLI
app.
Fixes: #475
Signed-off-by: Wesley Schwengle wesley@schwengle.net