Fix non-default PKG_CONFIG_PATH on macOS #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKG_CONFIG_PATH shouldn't be reset, only appended to or prepended to, so that the user can still use non-default paths if they need to. Additionally, package managers other than Homebrew (such as Nix) still need to be able to provide their own versions of packages, and aren't going to use Homebrew's default path to do so. Signed-off-by: Alyssa Ross <hi@alyssa.is>
alyssais
force-pushed
the
pkg_config_path
branch
from
b88991a
to
685bccc
Compare
|
@GPaulovics, this fixes unintended consequences from the previous |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PKG_CONFIG_PATH shouldn't be reset, only appended to or prepended to, so that the user can still use non-default paths if they need to. Additionally, package managers other than Homebrew (such as Nix) still need to be able to provide their own versions of packages, and aren't going to use Homebrew's default path to do so.