-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frames do not match in 'not top level in wrap-native for #<subr read-event>' (root case: TTY terminal init happens in each new TTY emacsclient (emacsclient -nw), which does readkey
)
#50
Comments
Hi, I literally just discovered this also just now while trying to make a video for the README. Uh, I tested new frames and emacsclient in windowed mode, I tested emacsclient in TTY, but I didn't test TTY emacsclient when you "create a new TTY window", because, I didn't know that feature existed.... O.o I already have a fix halfway written... thanks for reporting ❤️ should have that done in a couple hours... Also, this backtrace shows I need to update the README even more and make sure people bytecompile, it's way faster bytecompiled now. |
readkey
)
Further details:
Conclusions:
|
functions. Install earlier when called in init.el. * When enabled, wrap all existing processes and timers, so that if they call newly advised functions, the command stack is correct. * Advise `terminal-init-xterm` specially, because it calls `read-event`. This happens during emacs display system initialization, outside any user-action, so it didn't have a command record. By adding one, we can startup earlier.. so * Make explain-pause-mode install hooks immediately when loaded directly in init.el but not when called from the command-line (as calling from the commandline has `call-interactively` interleaved.) This fixes #50.
May be helpful. |
@condy0919 let me move this bug into another bug. I am going to merge this bug fix today as I wrote a test case for it and it will automatically close the issue when the PR is merged. Plus it’s a different bug - the call stack indicates it’s in post command hook - I know what’s wrong, fix it today. Sorry for breaking all the things in that big PR :( at least I added a bug report feature HAHA |
* Test that we wrap all existing things during init.
* When enabled, wrap all existing processes and timers, so that if they call newly advised functions, the command stack is correct. This fixes #50.
* When enabled, wrap all existing processes and timers, so that if they call newly advised functions, the command stack is correct. This fixes #50.
I've merged this, @nolanl let me know if it works or not. I did manually test |
Wow, fast turnaround. Thanks! |
I felt embarrassment for missing that especially after writing so many tests 🤣 |
Ran "emacsclient -nw" and got a "explain-pause-mode-report-bug" buffer containing:
The text was updated successfully, but these errors were encountered: