Wrap post and pre command hooks with frames. #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post and pre command hooks are run from
keyboard.c
outside the command loop, so they don't have any command frame parents.Advise
add-hook
so that we advise hooks added topre
andpost
command hooks so that the hooks themselves add frames before running the original hook.When enabling, go through all existing hooks and make sure they are also advised.
Fixes #54.
CHANGELOG