Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Create React App to Vite #802

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Migrate Create React App to Vite #802

merged 4 commits into from
Jun 22, 2022

Conversation

likui628
Copy link
Contributor

No description provided.

@likui628
Copy link
Contributor Author

close #524

@likui628 likui628 marked this pull request as draft June 22, 2022 03:11
@likui628 likui628 changed the title WIP: Migrate Create React App to Vite Migrate Create React App to Vite Jun 22, 2022
@likui628 likui628 marked this pull request as ready for review June 22, 2022 11:25
@likui628
Copy link
Contributor Author

@ryota-murakami please take a look

@ryota-murakami
Copy link
Collaborator

@likui628 Awesome! Thank you for great PR!
Could you tell me which source did you followed for setup swc + jest?

@ryota-murakami ryota-murakami merged commit a5ac695 into laststance:master Jun 22, 2022
@ryota-murakami ryota-murakami mentioned this pull request Jun 22, 2022
Closed
@ryota-murakami
Copy link
Collaborator

@all-contributors please add @likui628 for code

@allcontributors allcontributors bot mentioned this pull request Jun 22, 2022
Merged
@allcontributors
Copy link
Contributor

@ryota-murakami

I've put up a pull request to add @likui628! 🎉

@likui628
Copy link
Contributor Author

likui628 commented Jun 23, 2022 •
edited
Loading

@likui628 Awesome! Thank you for great PR! Could you tell me which source did you followed for setup swc + jest?

https://hung.dev/jest-vite

haha, the author @nvh95 has contributed to your other repository.

@ryota-murakami
Copy link
Collaborator

@likui628 Thanks!

@nvh95
Copy link

nvh95 commented Jun 23, 2022

@likui628 It's nice to know that my article helps.
Previously, I migrated CRA app to Vite for https://bestofjs.org. If you are interested, you can see more at the PR
Increase Developer Experience by replacing Create React App with Vite. I noted all the work I need to do to migrate from CRA to Vite in the PR description.

@ryota-murakami Hi Ryota, here we met again 😝.

@ryota-murakami
Copy link
Collaborator

@nvh95 Hey! That's your article LMAO 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@likui628 @ryota-murakami @nvh95