Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate agents to spaces (n-dim) from sizes (1-dim) #14

Merged
merged 9 commits into from
Aug 12, 2021
Merged

Conversation

laszukdawid
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #14 (d71aa1a) into master (9f07898) will increase coverage by 0.28%.
The diff coverage is 93.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   77.06%   77.34%   +0.28%     
==========================================
  Files          35       36       +1     
  Lines        4089     4172      +83     
==========================================
+ Hits         3151     3227      +76     
- Misses        938      945       +7     
Impacted Files Coverage Δ
ai_traineree/agents/d4pg.py 52.94% <71.42%> (+0.63%) ⬆️
ai_traineree/multiagent_env_runner.py 50.13% <77.77%> (-0.14%) ⬇️
ai_traineree/agents/dqn.py 77.50% <81.81%> (-0.28%) ⬇️
ai_traineree/env_runner.py 89.34% <90.00%> (+0.22%) ⬆️
ai_traineree/multi_agent/maddpg.py 84.02% <92.30%> (+0.17%) ⬆️
ai_traineree/types/dataspace.py 92.59% <92.59%> (ø)
ai_traineree/agents/sac.py 75.22% <95.45%> (+0.45%) ⬆️
ai_traineree/__init__.py 68.75% <100.00%> (ø)
ai_traineree/agents/agent_factory.py 94.73% <100.00%> (ø)
ai_traineree/agents/d3pg.py 83.58% <100.00%> (+0.52%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f07898...d71aa1a. Read the comment docs.

@laszukdawid laszukdawid merged commit d23fe6c into master Aug 12, 2021
@laszukdawid laszukdawid deleted the spaces branch August 12, 2021 19:29
laszukdawid added a commit that referenced this pull request Nov 21, 2021
Added DataSpace type which (as the name suggests) describes space of data. It's similar to gym's spaces and can be used as its wrapper. This is requirement to move with agents into multi dimensional input and output spaces with consistent interface.

Most agents have been tested and made sure that nothing has been changed from performance. Some, however, will need to be extra tested to make sure that algorithms work properly.

This PR also drops support for Python3.6. We're using a few features that are only in 3.8+ like `cached_property` or recurrent annotations. This bumps the version to v0.2.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant