You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if (!isset($productsInCategory[$new_products->fields['products_id']])) $productsInCategory[$new_products->fields['products_id']] = zen_get_generated_category_path_rev($new_products->fields['master_categories_id']);
The ordering is actually inconsequential, since the two lines are dealing with separate elements. That said, the module is sorely in need of some refactoring and I'll put the order back to the core's version, albeit with PSR-12 formatting so that single-line if statement will be braced.
lat9
added a commit
to lat9/zencart
that referenced
this issue
Jul 15, 2022
... and readability. Based on my looking at [this](lat9/ZCA-Bootstrap-Template#130) issue for the ZCA Bootstrap-4 template and getting the implementations "in line".
Regarding these two lines in the BS file:
ZCA-Bootstrap-Template/includes/modules/bootstrap/centerboxes/new_products.php
Lines 69 to 74 in 875f9dd
They are reversed to the core file (156/7/8):
https://github.com/zencart/zencart/blob/90a0a1f4a44f0d08712b9ab8e597d7054b8c949c/includes/modules/new_products.php#L67-L69
So one of them is "wrong"....
The text was updated successfully, but these errors were encountered: