Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in-line color classes from templates #215

Closed
dennisns7d opened this issue Feb 20, 2023 · 3 comments
Closed

Remove in-line color classes from templates #215

dennisns7d opened this issue Feb 20, 2023 · 3 comments
Labels
bug Something isn't working fix provided A correction has been provided
Milestone

Comments

@dennisns7d
Copy link

A few more potential trouble areas can be found by searching for bg-success, bg-primary, and badge-primary in the Catalog files.

For example, the use of bg-success in tpl_address_book_default.php fails the ANDI contrast check. The use of bg-primary passes the AA large text check, but not the AAA criteria.

@lat9 lat9 added the bug Something isn't working label Feb 20, 2023
@lat9 lat9 added this to the v3.5.2 milestone Feb 20, 2023
@lat9
Copy link
Owner

lat9 commented Feb 20, 2023

... and on the 3-page checkout pages' progress-bars (arggh).

@lat9
Copy link
Owner

lat9 commented Feb 20, 2023

Affected /template files:

  • tpl_address_book_default.php
  • tpl_create_account_success_default.php
  • tpl_modules_checkout_address_book.php

Affected /sideboxes files

  • tpl_document_categories.php

@lat9
Copy link
Owner

lat9 commented Feb 20, 2023

Those 3 address-related template files will require additional color-configuration settings:

  • ZCA_PRIMARY_ADDRESS_ADDRESS_BACKGROUND_COLOR, currently .bg-success
  • ZCA_PRIMARY_ADDRESS_ADDRESS_COLOR, currently .text-white
  • ZCA_PRIMARY_ADDRESS_CARD_HEADER_BACKGROUND_COLOR, currently .bg-primary
  • ZCA_PRIMARY_ADDRESS_CARD_HEADER_COLOR, currently .text-white
  • ZCA_PRIMARY_ADDRESS_CARD_BORDER_COLOR, currently border-primary.

lat9 added a commit that referenced this issue Feb 20, 2023
@lat9 lat9 added the fix provided A correction has been provided label Feb 20, 2023
@lat9 lat9 changed the title Additional color problem areas Remove in-line color classes from templates Feb 20, 2023
@lat9 lat9 closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix provided A correction has been provided
Projects
None yet
Development

No branches or pull requests

2 participants