Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating Star's Default color/background-color Changes #274

Closed
dbltoe opened this issue Aug 16, 2023 · 3 comments
Closed

Rating Star's Default color/background-color Changes #274

dbltoe opened this issue Aug 16, 2023 · 3 comments
Labels
change New feature or request fix provided A correction has been provided
Milestone

Comments

@dbltoe
Copy link

dbltoe commented Aug 16, 2023

Came across a new (to me) contrast checker at https://github.com/ThePacielloGroup/CCAe. One advantage of this checker is that you can "lock in" shades and, using the left and right arrows, change r, g, and b at the same time.

I was playing with its extra features and decided to give the rating star thing a try with the original background of #ffffff as I've never been fond of the workaround we had to do.

The result was #987000 which looks like a viable alternative. It's especially better than having the #322424 background with #efa31d and it meets the color contrast ratio for that item in all the testers I have at my disposal.

Take a look at the result on haredoDOTcom and see what you think. If you like it, throw it in whenever you feel appropriate.

I didn't want to muddy up the important stuff with a PR for this.

@lat9 lat9 added the change New feature or request label Aug 19, 2023
@lat9
Copy link
Owner

lat9 commented Jan 11, 2024

#987000 is, IMO, as ugly as the current #322424:
image

What's so wrong with a white background?
image

@lat9 lat9 added this to the v3.6.2 milestone Jan 11, 2024
@lat9
Copy link
Owner

lat9 commented Jan 11, 2024

What about changing the background to #ffffff and the color to #987000? Does that make the contrast better:
image

@dbltoe
Copy link
Author

dbltoe commented Jan 11, 2024

Using #987000 with #ffffff as the background is the absolute minimum contrast that still looks like gold and exceeds minimums at 4.51:1 in contrast, which is what I intended with the original post.
The current default of #efs31d results in a contrast ratio of 2.12:1. Total failure.

@lat9 lat9 added the fix provided A correction has been provided label Jan 11, 2024
@lat9 lat9 changed the title Possible Rating Star Change Rating Star's Default color/background-color Changes Jan 11, 2024
@lat9 lat9 closed this as completed Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change New feature or request fix provided A correction has been provided
Projects
None yet
Development

No branches or pull requests

2 participants