Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use FA-6, allow preloading to be disabled #358

Closed
lat9 opened this issue Apr 24, 2024 · 0 comments
Closed

Update to use FA-6, allow preloading to be disabled #358

lat9 opened this issue Apr 24, 2024 · 0 comments
Labels
change New feature or request fix provided A correction has been provided
Milestone

Comments

@lat9
Copy link
Owner

lat9 commented Apr 24, 2024

... as supplied in this PR.

@lat9 lat9 added the change New feature or request label Apr 24, 2024
@lat9 lat9 added this to the v3.7.0 milestone Apr 24, 2024
lat9 pushed a commit that referenced this issue Apr 28, 2024
* Update html_header.php

Have updated html header to font Awesome 6
Corrected error that stopped preload working
change loads to loop rather than hard coded list

Have left in the fa4-shim as bootstrap was on fa-5 it is probably not required. will take out if you don't want it.

* Added no preload to boostrap site specific settings

* Bring up to date with 3.7.0 and requested changes

* Font awsome 6.5.2 + rebase to 3.7.0
lat9 added a commit that referenced this issue Apr 28, 2024
- With minor reformatting to common/html_header.php
lat9 added a commit that referenced this issue Apr 28, 2024
- Previous versions of the template were based on FA-5, not FA-4, so no need for a FA-4 shim.
@lat9 lat9 added the fix provided A correction has been provided label Apr 28, 2024
@lat9 lat9 closed this as completed May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change New feature or request fix provided A correction has been provided
Projects
None yet
Development

No branches or pull requests

1 participant