Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable a site to "not display" categories with no products #360

Closed
lat9 opened this issue Apr 25, 2024 · 4 comments
Closed

Enable a site to "not display" categories with no products #360

lat9 opened this issue Apr 25, 2024 · 4 comments
Labels
change New feature or request fix provided A correction has been provided
Milestone
v3.7.0

Comments

@lat9
Copy link
Owner

lat9 commented Apr 25, 2024

... as submitted via PR #357.
@lat9 lat9 added the change New feature or request label Apr 25, 2024
@lat9 lat9 added this to the v3.7.0 milestone Apr 25, 2024
@lat9
Copy link
Owner Author

lat9 commented Apr 25, 2024

Noting that the referenced PR deals with the "Categories Tabs" only; I'll be updating the categories' sidebox to also adhere to this setting.

lat9 added a commit that referenced this issue Apr 25, 2024
@lat9
#360: Additional refactoring
ad7aaf0
@torvista
Copy link

While you're fiddling with this, I would comment that I've just modified it to allow the manual specifying of categories to skip.
Maybe that's an edge case or something worth including for these queries?

lat9 added a commit that referenced this issue Apr 25, 2024
@lat9
#360: Categories' sidebox and category-row updates
867bbe9 
- Refactoring for categories' sidebox
- Add support in category-row so that zero-product categories aren't displayed
@lat9 lat9 mentioned this issue Apr 25, 2024
Merged
lat9 added a commit that referenced this issue Apr 25, 2024
@lat9
Apply zero-product categories' change to sidebox and category-row mod…
334ac78 
…ules (#361)

* Updating versions, categories-sidebox for 0-product categories

* #360: Categories' sidebox and category-row updates

- Refactoring for categories' sidebox
- Add support in category-row so that zero-product categories aren't displayed
@lat9
Copy link
Owner Author

lat9 commented Apr 25, 2024 •
edited

While you're fiddling with this, I would comment that I've just modified it to allow the manual specifying of categories to skip. Maybe that's an edge case or something worth including for these queries?

That's a site-specific edge-case, which is why templates can be overridden!

lat9 added a commit that referenced this issue Apr 25, 2024
@lat9
#360: Updating readme.html/admin-init
4c63448
@lat9 lat9 added the fix provided A correction has been provided label Apr 25, 2024
@lat9
Copy link
Owner Author

lat9 commented Apr 25, 2024

For downward-compatibility, I'll be switching the default from "don't display" to "display".

lat9 added a commit that referenced this issue Apr 25, 2024
@lat9
#360: Swap soft-setting's default for downward compatibility
16a8a11
lat9 added a commit that referenced this issue May 14, 2024
@lat9
#360: Account for 'Show Category Count' setting
bdec3b9 
Fixes #383

Closing the above issue with this commit, since the issue was introduced in the subject-referenced issue's update.
@lat9 lat9 closed this as completed May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change New feature or request fix provided A correction has been provided
Projects
None yet
Milestone
v3.7.0
Development

No branches or pull requests
2 participants
@lat9 @torvista