Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Down for maintenance for others messages flashes then disappears #385

Closed
scottcwilson opened this issue May 18, 2024 · 2 comments
Closed
Labels
bug Something isn't working fix provided A correction has been provided
Milestone

Comments

@scottcwilson
Copy link

The message

'TEXT_ADMIN_DOWN_FOR_MAINTENANCE' => 'NOTICE: The website is currently down for maintenance to the public',

is not displayed as expected.

Repro steps: for a site on the public Internet, be sure your IP is in the Down For Maintenance (exclude this IP-Address) list, then put the site down for maintenance. Open the storefront, and observe that the message does not stay up.

@dbltoe
Copy link

dbltoe commented May 18, 2024

Taking a quick inspect, it looks like the simplest fix is to move it after the headerWrapper and in front of the navMainWrapper.

@lat9 lat9 added the bug Something isn't working label May 19, 2024
@lat9 lat9 added this to the v3.7.0 milestone May 19, 2024
@lat9
Copy link
Owner

lat9 commented May 19, 2024

The fixed-navbar was 'getting in the way'. I'll be moving those 'header' messages below the logo section in the header, keeping the navbar+logo together:
image

lat9 added a commit that referenced this issue May 19, 2024
... they were being hidden by the fixed-top navbar.
@lat9 lat9 added the fix provided A correction has been provided label May 19, 2024
@lat9 lat9 closed this as completed May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix provided A correction has been provided
Projects
None yet
Development

No branches or pull requests

3 participants