Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing font-awesome icons in edit orders address block #235

Closed
daphilli224 opened this issue Mar 8, 2024 · 3 comments
Closed

Missing font-awesome icons in edit orders address block #235

daphilli224 opened this issue Mar 8, 2024 · 3 comments
Labels
bug fix provided zen core Issue results from zen-cart core change
Milestone

Comments

@daphilli224
Copy link

The icons (customer, billing and shipping) are missing on the admin edit orders page address blocks. They are displayed on the orders details page. Should be an easy fix, but I don't know where to fix it.
Dave
zc158a, php 8.2, edit orders 4.7.0, sba, bootstrap 3.6.3.

@daphilli224
Copy link
Author

Some more information...I found that font-awesome classes fa-lg, fa-solid, and fa-regular did not show up in a search of admin/includes/css/font-awesome.min.css. On the order details screen, classes fa and fa-2x were used (in addition to fa-user, fa-credit-card, and fa-truck). I deleted fa-solid and fa-regular from admin/includes/modules/edit_orders/eo_edit_action_addresses_display.php in lines 30, 45, 51, 67, and 73, and replaced fa-lg with fa fa-2x on line 31 in admin/includes/modules/edit_orders/eo_common_address_format.php. The icons were then displayed normally in the edit orders page.

But... fa-lg is used in many other places in zc1.5.8a, so I can not explain what's going on.

I hope this provides some clues to a fix.

Thanks for the new update!

@lat9 lat9 added bug zen core Issue results from zen-cart core change labels Mar 11, 2024
@lat9 lat9 added this to the v4.7.1 milestone Mar 11, 2024
@lat9
Copy link
Owner

lat9 commented Mar 11, 2024

Thanks for the details, @daphilli224. That's a by-product of my testing being done on the zc200, where the FA support changed.

@daphilli224
Copy link
Author

This problem is fixed in 4.7.1.

@lat9 lat9 closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix provided zen core Issue results from zen-cart core change
Projects
None yet
Development

No branches or pull requests

2 participants