Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New configuration settings in version 4.3.4 not added to database when performing clean install #87

Closed
siliconforks opened this issue Oct 7, 2018 · 2 comments

Comments

@siliconforks
Copy link
Contributor

Version 4.3.4 appears to have two new configuration settings:

  1. Product Price Calculation — Method (EO_PRODUCT_PRICE_CALC_METHOD)
  2. Product Price Calculation — Default (EO_PRODUCT_PRICE_CALC_DEFAULT)

I had a site running an old version of Edit Orders and I upgraded it to version 4.3.4; these settings appeared in the admin section under Configuration → Edit Orders, as expected. Looking in the database, I can see rows in the configuration table for EO_PRODUCT_PRICE_CALC_METHOD and EO_PRODUCT_PRICE_CALC_DEFAULT.

However, I had another site without Edit Orders installed where I performed a clean install of version 4.3.4, and neither of these settings showed up in the admin section. Looking in the database, neither EO_PRODUCT_PRICE_CALC_METHOD nor EO_PRODUCT_PRICE_CALC_DEFAULT are in the configuration table.

Is this the intended behavior? (I haven't used version 4.3.4 before and I'm not exactly sure what these settings do, but surely they should be present no matter whether Edit Orders is upgraded from an older version or installed for the first time?)

@lat9
Copy link
Owner

lat9 commented Oct 7, 2018

You're correct, of course, @siliconforks. Let me get a 4.3.5 version going to correct.

@lat9 lat9 added the bug label Oct 7, 2018
lat9 added a commit that referenced this issue Oct 7, 2018
... where configuration settings aren't correctly added.
@lat9 lat9 added this to the v4.3.5 milestone Oct 7, 2018
@lat9
Copy link
Owner

lat9 commented Oct 7, 2018

I've updated EO's admin initialization module to correct the issue; thanks for the report!

lat9 added a commit that referenced this issue Oct 30, 2018
Catch the readme up with the subject changes.
@lat9 lat9 closed this as completed Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants