Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to load *after* currencies are instantiated #13

Closed
lat9 opened this issue Mar 29, 2023 · 1 comment
Closed

Need to load *after* currencies are instantiated #13

lat9 opened this issue Mar 29, 2023 · 1 comment
Labels
bug Something isn't working fix provided An update has been provided
Milestone
v1.2.3

Comments

@lat9
Copy link
Owner

lat9 commented Mar 29, 2023

... as identified in this Zen Cart support-thread posting.
@lat9 lat9 added the bug Something isn't working label Mar 29, 2023
@lat9 lat9 added this to the v1.1.1 milestone Mar 29, 2023
lat9 added a commit that referenced this issue Mar 29, 2023
@lat9
#13: Load observer *after* currencies are present
31a4bc7
@lat9 lat9 added the fix provided An update has been provided label Mar 29, 2023
@lat9 lat9 closed this as completed Apr 15, 2023
@lat9 lat9 reopened this Oct 16, 2023
@lat9
Copy link
Owner Author

lat9 commented Oct 16, 2023

Re-opening, since CP 120 is where the currencies are initialized. Some sites are still seeing the warning, possibly due to file-system-specific load-ordering of the auto_loaders files. Changing to CP 121 should fully correct the issue.

@lat9 lat9 modified the milestones: v1.2.0, v1.2.3 Oct 16, 2023
@lat9 lat9 removed the fix provided An update has been provided label Oct 22, 2023
lat9 added a commit that referenced this issue Oct 22, 2023
@lat9
#13: Load storefront observer at CP 121 ...
3e39777 
... guaranteed to be after the currencies class is instantiated.
@lat9 lat9 added the fix provided An update has been provided label Oct 22, 2023
@lat9 lat9 closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fix provided An update has been provided
Projects
None yet
Milestone
v1.2.3
Development

No branches or pull requests
1 participant
@lat9