Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zc157: Admin, missing $template_dir #20

Closed
lat9 opened this issue Jun 30, 2020 · 0 comments
Closed

zc157: Admin, missing $template_dir #20

lat9 opened this issue Jun 30, 2020 · 0 comments
Labels
fix provided A change has been supplied zc157 interoperation
Milestone

Comments

@lat9
Copy link
Owner

lat9 commented Jun 30, 2020

Seeing logs similar to:

[30-Jun-2020 09:16:06 America/New_York] Request URI: /vinos_157/admin/index.php?cmd=display_logs, IP address: ::1
#1 require_once(C:\xampp\htdocs\vinos_157\admin\includes\languages\english\extra_definitions\news_box_manager_menu_name.php) called at [C:\xampp\htdocs\vinos_157\includes\classes\ResourceLoaders\LanguageLoader.php:66]
#2 Zencart\LanguageLoader\LanguageLoader->loadFilesFromDirectory() called at [C:\xampp\htdocs\vinos_157\includes\classes\ResourceLoaders\LanguageLoader.php:44]
#3 Zencart\LanguageLoader\LanguageLoader->loadLanguageExtraDefinitions() called at [C:\xampp\htdocs\vinos_157\includes\classes\ResourceLoaders\LanguageLoader.php:23]
#4 Zencart\LanguageLoader\LanguageLoader->loadLanguageDefines() called at [C:\xampp\htdocs\vinos_157\admin\includes\init_includes\init_languages.php:47]
#5 require_once(C:\xampp\htdocs\vinos_157\admin\includes\init_includes\init_languages.php) called at [C:\xampp\htdocs\vinos_157\includes\autoload_func.php:37]
#6 require(C:\xampp\htdocs\vinos_157\includes\autoload_func.php) called at [C:\xampp\htdocs\vinos_157\admin\includes\application_top.php:37]
#7 require(C:\xampp\htdocs\vinos_157\admin\includes\application_top.php) called at [C:\xampp\htdocs\vinos_157\zc_plugins\DisplayLogs\v3.0.0\admin\display_logs.php:35]
#8 require(C:\xampp\htdocs\vinos_157\zc_plugins\DisplayLogs\v3.0.0\admin\display_logs.php) called at [C:\xampp\htdocs\vinos_157\admin\index.php:23]
--> PHP Notice: Undefined variable: template_dir in C:\xampp\htdocs\vinos_157\admin\includes\languages\english\extra_definitions\news_box_manager_menu_name.php on line 16.

The issue is that in zc157 the admin extra_definitions are now loaded via a LanguageLoader class method, so the $template_dir variable now needs to be declared as a global.

@lat9 lat9 added this to the v3.0.5 milestone Jun 30, 2020
@lat9 lat9 added the fix provided A change has been supplied label Jun 30, 2020
@lat9 lat9 closed this as completed Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix provided A change has been supplied zc157 interoperation
Projects
None yet
Development

No branches or pull requests

1 participant