Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zc157 inter-operation, login page's form's name was changed #260

Closed
dbltoe opened this issue Jun 13, 2020 · 4 comments
Closed

zc157 inter-operation, login page's form's name was changed #260

dbltoe opened this issue Jun 13, 2020 · 4 comments

Comments

@dbltoe
Copy link

dbltoe commented Jun 13, 2020

After about the fifth setup, I discovered that UltraCompare was giving me a glitch and not properly updating an OPC file.

I can now say that I have a beta with mod list and OPC being the only mods (other than Display Logs installed from the new Plugins Manager).

All works exactly as advertised UNLESS Guest Checkout is set to true.

With Guest Checkout set to true, clicking on Log In from the home page, an uncaught error shows in the console.
~~ Also, clicking on Place Order in the Customers portion of the admin results in the "Whoops, your session has expired."~~

OPC debug is on but no error appears in the logs.

Just a WAG but, I think it may be in the way the body tag is generated for the login page.

Sorry I can't be of more help than that. Can easily grant access to the site if needed for testing.

@dbltoe
Copy link
Author

dbltoe commented Jun 14, 2020

Found out more info that is actually causing the Whoops. I has nothing to do with OPC or it's Guest Checkout
https://github.com/zencart/zencart/issues/3587

Still have the uncaught error if Guest Checkout is true and Log In is clicked.

The good news is that the uncaught error does NOT stop someone from logging in to the site.

@lat9
Copy link
Owner

lat9 commented Jun 14, 2020

That uncaught error on the OPC login page is due to this change in form names for zc157.

All prior versions of Zen Cart named that form login, while zc157 now names it loginForm.

Let me consider how best to support this zc157 change.

@dbltoe
Copy link
Author

dbltoe commented Jun 14, 2020

Have the test site with the situation available if needed.

@lat9
Copy link
Owner

lat9 commented Jun 14, 2020

Thanks, I've replicated the issue locally.

@lat9 lat9 changed the title Guest Checkout blocks EMP and Place Order in 1.5.7 zc157 inter-operation, login page's form's name was changed Jun 14, 2020
@lat9 lat9 added this to the v2.3.3 milestone Jun 14, 2020
@lat9 lat9 closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants