Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id never gets added to form #391

Closed
proseLA opened this issue Jan 10, 2024 · 0 comments · Fixed by #392
Closed

id never gets added to form #391

proseLA opened this issue Jan 10, 2024 · 0 comments · Fixed by #392

Comments

@proseLA
Copy link
Contributor

proseLA commented Jan 10, 2024

surprising no one has found this before.

these lines need to be changed:

<?php
// -----
// Now, display the form that actually submits this order.
//
echo zen_draw_form('checkout_confirmation', $form_action_url, 'post', 'id="checkout_confirmation"' . ($confirmation_required) ? ' onsubmit="submitonce();"' : '');
?>

<?= zen_draw_form('checkout_confirmation', $form_action_url, 'post', 'id="checkout_confirmation"' . (($confirmation_required) ? ' onsubmit="submitonce();"' : ''));  ?>

the string concatenation was taken precedence over the conditional, therefore the id tag never made it onto the form. which is no doubt not intended. therefore the extra parenthesis are needed.

drbyte added a commit to drbyte/one_page_checkout that referenced this issue Jan 10, 2024
@lat9 lat9 closed this as completed in #392 Jan 10, 2024
@lat9 lat9 reopened this Jan 10, 2024
@lat9 lat9 added the bug label Jan 10, 2024
@lat9 lat9 added this to the v2.4.7 milestone Jan 10, 2024
lat9 added a commit that referenced this issue Jan 10, 2024
- Remove extraneous blanks and update last-version for changed file
- Update admin-reported version.
@lat9 lat9 closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants