Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review class file for performance and potential simplification #39

Closed
lat9 opened this issue Apr 24, 2023 · 1 comment
Closed

Review class file for performance and potential simplification #39

lat9 opened this issue Apr 24, 2023 · 1 comment
Labels
change
Milestone
v4.0.0

Comments

@lat9
Copy link
Owner

lat9 commented Apr 24, 2023

... as many of the methods are quite large!
@lat9 lat9 added the change label Apr 24, 2023
@lat9 lat9 added this to the v4.0.0 milestone Apr 24, 2023
lat9 added a commit that referenced this issue Apr 25, 2023
@lat9
#39: Class file updates
773facb 
- Using exactly-equal-to where warranted.
- Cast (bool)/(int) parameters to keep the class 'sane'.
- Gather only database fields needed instead of `*`.
- Simplify 'matrix' mode calculations
@lat9
Copy link
Owner Author

lat9 commented Apr 25, 2023

Removing 'fix provided' because there are a plethora of orders table values that can be grabbed on the initial query without 'hitting' the database multiple sub-sequential times to gather additional information.

lat9 added a commit that referenced this issue Apr 25, 2023
@lat9
#39: Gather *all* orders-table elements at one time ...
e7bd693 
... for performance.  Otherwise, there are itty-bitty queries on an order-by-order basis when the various timeframes' information is gathered.
lat9 added a commit that referenced this issue Apr 27, 2023
@lat9
#39: Updating order-total validations for rounding
60638f9
lat9 added a commit that referenced this issue Apr 27, 2023
@lat9
#39: Using strtotime instead of mktime ...
17e3335 
... for readability.
@lat9 lat9 closed this as completed Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
1 participant
@lat9