Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to check 'is_countable' for PHP 7.2/3 #11

Closed
lat9 opened this issue Sep 17, 2018 · 1 comment
Closed

Need to check 'is_countable' for PHP 7.2/3 #11

lat9 opened this issue Sep 17, 2018 · 1 comment
Labels
bug fix provided
Milestone
v2.0.0

Comments

@lat9
Copy link
Owner

lat9 commented Sep 17, 2018

As noted by @Zen4All on the plugin's support thread:

On a test server I have

  • Zen Cart version 1.5.5f
  • PHP 7.2.9

I am getting the following warnings

[17-Sep-2018 10:33:05 Europe/Amsterdam] PHP Warning:  sizeof(): Parameter must be an array or an object that implements Countable in /home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/functions/extra_functions/superglobals.php on line 174
[17-Sep-2018 10:33:05 Europe/Amsterdam] Request URI: /index.php?main_page=compare, IP address: 143.177.116.2#1  sizeof() called at [/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/functions/extra_functions/superglobals.php:174]
#2  superglobals_format() called at [/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/functions/extra_functions/superglobals.php:221]
#3  superglobals_format() called at [/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/functions/extra_functions/superglobals.php:211]
#4  superglobals_format() called at [/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/functions/extra_functions/superglobals.php:60]
#5  superglobals_echo() called at [/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/templates/responsive_classic/common/tpl_main_page.php:274]
#6  require(/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/index.php:97]

[17-Sep-2018 10:33:05 Europe/Amsterdam] PHP Warning:  sizeof(): Parameter must be an array or an object that implements Countable in /home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/functions/extra_functions/superglobals.php on line 174
[17-Sep-2018 10:33:05 Europe/Amsterdam] Request URI: /index.php?main_page=compare, IP address: 143.177.116.2
#1  sizeof() called at [/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/functions/extra_functions/superglobals.php:174]
#2  superglobals_format() called at [/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/functions/extra_functions/superglobals.php:221]
#3  superglobals_format() called at [/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/functions/extra_functions/superglobals.php:211]
#4  superglobals_format() called at [/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/functions/extra_functions/superglobals.php:60]
#5  superglobals_echo() called at [/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/templates/responsive_classic/common/tpl_main_page.php:274]
#6  require(/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/home/zen4all-dev/domains/compare.zen4all-dev.nl/public_html/index.php:97]

This may need some fixing in a future version
@lat9 lat9 added the bug label Sep 17, 2018
lat9 added a commit that referenced this issue Sep 17, 2018
@lat9
#11: Add check for 'is_countable'
9c14549
@lat9 lat9 added this to the v1.6.6 milestone Sep 17, 2018
@lat9
Copy link
Owner Author

lat9 commented Sep 17, 2018

@Zen4All, would you validate that the above change corrects the issue?

lat9 added a commit that referenced this issue Jan 7, 2019
@lat9
#11: Need to check is_object, too ...
cce7981 
... or the order-object isn't rendered.
lat9 added a commit that referenced this issue Jan 7, 2019
@lat9
#11, #12: Identify changes for associated issues ...
16811ca 
... and document how to perform an initial installation.
@lat9 lat9 closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fix provided
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@lat9