Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

UPSXML rates not showing prior to login (shipping estimator) #37

Open
lat9 opened this issue May 19, 2023 · 2 comments
Open

UPSXML rates not showing prior to login (shipping estimator) #37

lat9 opened this issue May 19, 2023 · 2 comments

Comments

@lat9
Copy link
Owner

lat9 commented May 19, 2023

From the Zen Cart support-thread (@scottcwilson):

Small bug in a recent update.

line 387
if ($next_zone['zone_id'] < 1 || $next_zone['zone_id'] === $order->delivery['zone_id']) {

fails to work because of ===. $next_zone['zone_id'] is not an int the way $order->delivery['zone_id'] is.
Casting fixes.

The symptom is the shipping estimator does not show UPSXML rates prior to login.

@lat9 lat9 added the bug label May 19, 2023
@scottcwilson
Copy link

@scottcwilson
Copy link

Follow up note - I wound up casting both sides because this kept failing. An easier fix would be to switch from === back to == to prevent this issue from occurring.

@lat9 lat9 added this to the v1.8.2 milestone May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants