Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify logging to use PHP's error_log function #2

Closed
lat9 opened this issue Nov 29, 2018 · 0 comments
Closed

Modify logging to use PHP's error_log function #2

lat9 opened this issue Nov 29, 2018 · 0 comments
Labels
change New feature or request fix provided Code change provided for the issue
Milestone

Comments

@lat9
Copy link
Owner

lat9 commented Nov 29, 2018

The current approach of USU's logging feature can result in issues, see this Zen Cart posting for additional information.

The logging currently uses a stream that must be shut down when the class is destroyed instead of simply using the PHP error_log function, which manages file open/closing quite nicely. I'll be changing the log-output function and initialization to make use of that.

@lat9 lat9 added the change New feature or request label Nov 29, 2018
@lat9 lat9 added this to the v3.0.0 milestone Feb 8, 2019
lat9 added a commit that referenced this issue Feb 12, 2019
@lat9 lat9 added the fix provided Code change provided for the issue label Feb 12, 2019
@lat9 lat9 closed this as completed Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change New feature or request fix provided Code change provided for the issue
Projects
None yet
Development

No branches or pull requests

1 participant