Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack attempts generating errors #38

Closed
proseLA opened this issue Dec 14, 2020 · 4 comments
Closed

hack attempts generating errors #38

proseLA opened this issue Dec 14, 2020 · 4 comments
Labels
bug Something isn't working fix provided Code change provided for the issue
Milestone

Comments

@proseLA
Copy link
Contributor

proseLA commented Dec 14, 2020

if ($parsed_uri['path'] != $this->redirect_uri['path'] && rawurldecode($parsed_uri['path']) != $this->redirect_uri['path']) {

hi cindy,
i am getting errors on this line:

PHP Notice: Undefined index: path

i have tracked it done in my logs to:

[14/Dec/2020:08:45:22 -0800] "GET //xmlrpc.php?rsd

its easy to test, as with logging set to ignoreDups or all you can enter:

yoursite.com//xmlrpc.php?rsd

and you should see the notices. i have been able to address this notice by changing the above line of code to:

if (!isset($parsed_uri['path']) || ($parsed_uri['path'] != $this->redirect_uri['path'] && rawurldecode($parsed_uri['path']) != $this->redirect_uri['path'])) {

best.
p.

@lat9 lat9 added the bug Something isn't working label Dec 25, 2020
@lat9 lat9 added this to the v3.0.7 milestone Dec 25, 2020
@lat9
Copy link
Owner

lat9 commented Dec 25, 2020

What version of Zen Cart? When I use that URL on a zc155f installation, I'm seeing the following in the network activity tab:

image

... and no associated PHP notices.

@proseLA
Copy link
Contributor Author

proseLA commented Dec 25, 2020

interesting, i'm running v157b. i see the same thing in the network tab. the redirect operates fine. when i do a print_r($parsed_uri); prior to that line, i only see the array elements of host and query.

are you sure you are using the double slash? ie, mysite.com//xmlrpc.php?rsd. the // is what causes the notice.

@lat9
Copy link
Owner

lat9 commented Dec 25, 2020

Agreed, on 155f with the // no notices from usu.php. I'm guessing that something, well a lot of somethings, changed in the years from 155f to 157b.

@lat9
Copy link
Owner

lat9 commented Dec 25, 2020

Since I can't re-create (I've not, yet, installed on zc157b), I'll take your word for the suggested change.

@lat9 lat9 added the fix provided Code change provided for the issue label Dec 26, 2020
@lat9 lat9 closed this as completed Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix provided Code change provided for the issue
Projects
None yet
Development

No branches or pull requests

2 participants