Use a single tool for setting up the token #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkcs11-tool is well capable of initializing a token, so just use it for everything and drop use of p11tool which is quirkier. Signed-off-by: Simo Sorce <simo@redhat.com>
Jakuje
reviewed
Jul 13, 2024
| --label "Pkcs11 Provider Tests" --so-pin "${PINVALUE}" 2>&1 | ||
| # set user pin | ||
| pkcs11-tool --module "${P11LIB}" --so-pin "${PINVALUE}" \ | ||
| --login --login-type so --init-pin --pin "${PINVALUE}" 2>&1 |
There was a problem hiding this comment.
nit: whats the point of forwarding the stderr to stdout like this? Arent both of them captured the same way by the test driver?
There was a problem hiding this comment.
They are not, I needed it to work out some issues.
But I already forgot how it exactly affected things, I think the main issue was just ordering, this way messages are in order otherwise you get all of stdout and then out of order all of stderr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pkcs11-tool is well capable of initializing a token, so just use it for everything and drop use of p11tool which is quirkier.
Checklist
[ ] Code modified for feature[ ] Test suite updated with negative tests[ ] Documentation updatedReviewer's checklist:
[ ] Any issues marked for closing are addressed[ ] This feature/change has adequate documentation added[ ] Coverity Scan has run if needed (code PR) and no new defects were found