Fixed Ordering cycle found, causing spurious issues during boot (no tangd.socket enabled, or no network, etc.) #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangd.socket enabled, or no network, etc.) This commit fixes the following ordering cycle found on Fedora 30+ and RHEL 8.1: -------- 8< ---------------- 8< ---------------- 8< ---------------- 8< -------- systemd[1]: sockets.target: Found ordering cycle on tangd.socket/start systemd[1]: sockets.target: Found dependency on tangd-keygen.service/start systemd[1]: sockets.target: Found dependency on basic.target/start systemd[1]: sockets.target: Found dependency on sockets.target/start systemd[1]: sockets.target: Job tangd.socket/start deleted to break ordering cycle starting with sockets.target/start [ SKIP ] Ordering cycle found, skipping Tang Server socket -------- 8< ---------------- 8< ---------------- 8< ---------------- 8< -------- This is tracked by Red Hat through BZ #1792173 (https://bugzilla.redhat.com/show_bug.cgi?id=1792173) The previous implementation of the Tang socket was making it depend on services, which is not how sockets are expected to be configured. Additionally, the Tang socket was installed in multi-user.target instead of sockets.target. This implementation creates a "standard" socket installed in sockets.target, and modifies the corresponding service so that it makes sure the requirement on the key presence is met. The requirement on tangd-update.service has been removed since it is useless: the service doesn't need tangd-update.service at all.
sergio-correia
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the following ordering cycle found on Fedora 30+ and RHEL 8.1:
This is tracked by Red Hat through BZ #1792173
The previous implementation of the Tang socket was making it depend on services, which is not how sockets are expected to be configured.
Additionally, the Tang socket was installed in
multi-user.targetinstead ofsockets.target.This implementation creates a standard socket installed in
sockets.target, and modifies the corresponding service so that it makes sure the requirement on the key presence is met.The requirement on
tangd-update.servicehas been removed since it is useless: the service doesn't needtangd-update.serviceat all.