Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: extend list of references #25

Closed
clason opened this issue Jun 24, 2019 · 2 comments
Closed

Discussion: extend list of references #25

clason opened this issue Jun 24, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@clason
Copy link
Contributor

clason commented Jun 24, 2019

This is actually two independent but related issues:

  1. Let "list all references" work from a reference, not just the label (e.g., trigger from \eqref{eq1}, not just \label{eq1}).
  2. If this is added, add the definition to the list as well.

But this might be annoying to some? In particular 2. may be redundant, since you can easily go directly to the definition.

@efoerster efoerster added the enhancement New feature or request label Jun 25, 2019
@efoerster efoerster added this to To do in Release 1.0.0 Jun 25, 2019
@pfoerster pfoerster moved this from To do to Done in Release 1.0.0 Jun 25, 2019
@pfoerster
Copy link
Member

Let "list all references" work from a reference, not just the label (e.g., trigger from \eqref{eq1}, not just \label{eq1}).

This should be fixed now. "Find all References" now works from a reference in addition to the label.

If this is added, add the definition to the list as well.

According to the LSP specification it is up to the client to decide whether to include the declaration.
We have changed the server to respect the user's choice.

@clason
Copy link
Contributor Author

clason commented Jun 30, 2019

This should be fixed now. "Find all References" now works from a reference in addition to the label.

Yes, can confirm, thank you!

According to the LSP specification it is up to the client to decide whether to include the declaration.
We have changed the server to respect the user's choice.

That seems indeed the best way.

@clason clason closed this as completed Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Release 1.0.0
  
Done
Development

No branches or pull requests

3 participants