Skip to content

Commit

Permalink
Using TU format means we are not using cmr
Browse files Browse the repository at this point in the history
At least, that makes sense and is I think why these
tests are failing. I'm pretty sure the format being used
is the correct (TU-active) one!
  • Loading branch information
josephwright committed Oct 2, 2019
1 parent 3274138 commit 6395e92
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion required/amsmath/testfiles-TU/tlb-utex-004.luatex.tlg
@@ -1,6 +1,5 @@
This is a generated file for the LaTeX2e validation system.
Don't change this file in any respect.
This test has error at begin document due to the special font setup in the test suite
Missing character: There is no − (U+2212) in font cmr10!
[1
] (tlb-utex-004.aux)
1 change: 0 additions & 1 deletion required/amsmath/testfiles-TU/tlb-utex-004.xetex.tlg
@@ -1,6 +1,5 @@
This is a generated file for the LaTeX2e validation system.
Don't change this file in any respect.
This test has error at begin document due to the special font setup in the test suite
Missing character: There is no − in font cmr10!
[1
] (tlb-utex-004.aux)
1 change: 0 additions & 1 deletion required/amsmath/testfiles-TU/tlb-utex-005.luatex.tlg
@@ -1,6 +1,5 @@
This is a generated file for the LaTeX2e validation system.
Don't change this file in any respect.
This test has error at begin document due to the special font setup in the test suite
Missing character: There is no − (U+2212) in font cmr10!
[1
] (tlb-utex-005.aux)
1 change: 0 additions & 1 deletion required/amsmath/testfiles-TU/tlb-utex-005.xetex.tlg
@@ -1,6 +1,5 @@
This is a generated file for the LaTeX2e validation system.
Don't change this file in any respect.
This test has error at begin document due to the special font setup in the test suite
Missing character: There is no − in font cmr10!
[1
] (tlb-utex-005.aux)

7 comments on commit 6395e92

@FrankMittelbach
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, this was not the case in the past (where the special setup copied from the support dir forced cmr. Thus the

This test has error at begin document due to the special font setup in the test suite

line in the lvt. If this is no longer done this way (not followed the recent changes), then this comment should vanish too as it is now quite misleading. But if the font setup has not deliberately changed then one better really understands why there is now this diff.

@josephwright
Copy link
Member Author

@josephwright josephwright commented on 6395e92 Oct 2, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidcarlisle
Copy link
Member

@davidcarlisle davidcarlisle commented on 6395e92 Oct 2, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephwright
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty confident that the previous behaviour was wrong, but I'll wait to hear from @davidcarlisle after he's had a proper look. If it is, I guess the comment needs to go.

@davidcarlisle
Copy link
Member

@davidcarlisle davidcarlisle commented on 6395e92 Oct 2, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrankMittelbach
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also appreciate the change as the old setup was causing more than once some head scratching. My point was only that I wanted to understand what was changed and if that was deliberate (eg not any longer using the crippled setup). So if this is intentional then lets go with it and update the lvt to not claim something that is no longer true ... as that will otherwise later cause some scratching :-)

@josephwright
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I was mainly checking that I'd got it right that the test outcome was supposed to be using a standard format. I'm sure that is now right: I will merge across.

Please sign in to comment.