Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug and typo in ltfssini.dtx #395

Closed
aminophen opened this issue Sep 30, 2020 · 2 comments
Closed

Possible bug and typo in ltfssini.dtx #395

aminophen opened this issue Sep 30, 2020 · 2 comments

Comments

@aminophen
Copy link
Contributor

aminophen commented Sep 30, 2020

First, sorry I cannot think of any MWE; but I think I spotted a typo and a possible bug in ltfssini.dtx. I will report them as follows, since the deadline 2020-10-01 is coming.

latex2e/base/ltfssini.dtx

Lines 803 to 819 in c7be0b9

% If \cs{bfdefault} and \cs{befdefault@previous} are different then
% the default got changed directly through the legacy interface
% (i.e., via \cs{def} or \cs{renewcommand}. In that case we reset
% all meta family defaults so that the document behaves like it was
% the case before the new mechanism was introduced.
% \changes{v3.1k}{2020/03/19}{Support legacy use of \cs{bfdefault}
% and \cs{mddefault} (gh/306)}
% \begin{macrocode}
\ifx\bfdefault\bfdefault@previous\else
% \end{macrocode}
% We add \cs{@empty} and then let \cs{bfdefault@previous} to
% \cs{bfdefault} so that we can detect any further change.
% \begin{macrocode}
\expandafter\def\expandafter\bfdefault
\expandafter{\bfdefault\@empty}%
\let\bfseries@previous\bfdefault
% \end{macrocode}

  • typo: l.803 \cs{befdefault@previous} should be \cs{bfdefault@previous}
  • possible bug: l.818 \bfseries@previous appears but this is the only one occurrence of \bfseries@previous inside the latex.ltx; I guess it should be \bfdefault@previous.

Maybe related to #306?

@aminophen
Copy link
Contributor Author

Similiar for \mdseries@previous: maybe \mddefault@previous?

@FrankMittelbach
Copy link
Member

FrankMittelbach commented Sep 30, 2020 via email

@FrankMittelbach FrankMittelbach self-assigned this Sep 30, 2020
@FrankMittelbach FrankMittelbach added this to Pool (unscheduled issues) in upcoming LaTeX2e releases via automation Sep 30, 2020
@FrankMittelbach FrankMittelbach added this to the release 2020 fall milestone Sep 30, 2020
@FrankMittelbach FrankMittelbach moved this from Pool (unscheduled issues) to In progress in upcoming LaTeX2e releases Sep 30, 2020
FrankMittelbach added a commit that referenced this issue Sep 30, 2020
@FrankMittelbach FrankMittelbach moved this from In progress to Done in upcoming LaTeX2e releases Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants