Distinguish protected ltcmds with only m-type args

[muzimuzhi]

READ ME FIRST: Please understand that in most cases we will not be able to merge a pull request because there are a lot of internal activities needed when updating the LaTeX2e sources. If you have a code suggestion please discuss it with the team first.

Pull requests in this repository are intended for LaTeX Team members only.

Internal housekeeping

This PR resolves issue #1009.

PS: What's the main difference between test2e.tex and regression-test.tex? It's observed that all testfiles-ltcmd/github-xxxx.lvt load the former and testfiles-ltcmd/ltcmdxxx.lvt loads the latter, but usages are not that consistent in other test suites.

Status of pull request

• Feedback wanted
• Ready to merge

Checklist of required changes before merge will be approved

• Test file(s) added
• Version and date string updated in changed source files
• Relevant \changes entries in source included
• Relevant changes.txt updated
• ltnewsX.tex (and/or latexchanges.tex) updated

[davidcarlisle]

PS: What's the main difference between test2e.tex and regression-test.tex

test2e.tex was developed along with latex2e so predates l3build by some decades. It is part of the latex sources but was never documented or distributed for general use.

regression-test.tex was developed as part of l3build and like the rest of l3build it is designed and documented for general use not only for the latex sources. It has more structured test commands than test2e.

For consistency, most 2e tests still test2e however code like ltcmd and lthooks are internally in l3 style and many tests use regression-test as do most of the tests in the latex3/latex3 repo. The two files produce log files in compatble formats and are normalised and checked by the same l3build functions.

[PhelypeOleinik]

Looks good to me. Thanks for the PR!

I added rollback code for this, but I think because the code is a fork under your account, I can't push directly. The code is in bab4318. If you could add that to the PR, then I do the merging.

Thanks again!

[muzimuzhi]

bab4318 cherry-picked.

I added rollback code for this, but I think because the code is a fork under your account, I can't push directly.

You can push to the branch in my fork as far as I checked "Allow edits and access to secrets by maintainers"

Also see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork.

PS: The GitHub CLI is good at checking out a PR through gh pr checkout 1013. But it's recent version introduced a limitation that one may have to manually check out the fetched branch, see cli/cli#4287.