Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh795 [ltcmdhooks] Adding hooks to simple macros cause them to expand #796

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

PhelypeOleinik
Copy link
Member

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • ltnewsX.tex (and/or latexchanges.tex) updated

If the first item is a braced group, more tokens are returned so a single \exp_not:N is not enough
@PhelypeOleinik
Copy link
Member Author

I think this doesn't need rollback, because the old version is simply broken with some macros, so rolling back to that seems like something people wouldn't want.

@FrankMittelbach
Copy link
Member

I think this doesn't need rollback, because the old version is simply broken with some macros, so rolling back to that seems like something people wouldn't want.

guess not, but should have some sort of roll forward in the sense, that if you start from current overleaf (which I think is early TL2021 you get it if you use a latexrelease for 2022-06

@PhelypeOleinik
Copy link
Member Author

Overleaf has LaTeX 2021-06-01, before I implemented \ShowCommand for ltcmd (and introduced this bug), so they don't have the bug. They may be affected if they install TeX Live 2022 before the next release though...

@PhelypeOleinik PhelypeOleinik merged commit c4a5a8c into develop Apr 22, 2022
@PhelypeOleinik PhelypeOleinik deleted the gh795 branch April 22, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants