Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust fd file for issue #879 #896

Merged
merged 13 commits into from
Jul 10, 2022
Merged

adjust fd file for issue #879 #896

merged 13 commits into from
Jul 10, 2022

Conversation

davidcarlisle
Copy link
Member

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • ltnewsX.tex (and/or latexchanges.tex) updated

Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small scale docu suggestions, and please check why you had to add ltnews36 and how that fits in with an existing one (in some branch)

base/changes.txt Outdated
@@ -6,6 +6,10 @@ completeness or accuracy and it contains some references to files that
are not part of the distribution.
================================================================================

2022-07-10 David Carlisle <David.Carlisle@latex-project.org>

* cmfonts.fdd: avoid EC ss fonts at small design sizes. Scale 8pt font. gh/879
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should say why eg , because they are broken or something

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add some words

Comment on lines 1 to 2
% \iffalse meta-comment
%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there is already a ltnews36 ... might be that it is in the umerged branch made by Ulrike (which should get merged)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in devlop, and I wanted to add a para somewhere. We should be able to handle that when merging the other branch (unless that is ready to go in first, in which case I'll rebase this after that goes in)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ulrike's PR now merged, touched exactly same set of files as this, cleaning up merge conflicts here...

base/doc/ltnews36.tex Outdated Show resolved Hide resolved
@davidcarlisle davidcarlisle merged commit 8baf999 into develop Jul 10, 2022
@davidcarlisle davidcarlisle deleted the gh879 branch July 10, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants