Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GH Actions context github.ref_name #996

Merged
merged 1 commit into from Feb 12, 2023

Conversation

muzimuzhi
Copy link
Contributor

hence drop action frabert/replace-string-action

READ ME FIRST: Please understand that in most cases we will not be able to merge a pull request because there are a lot of internal activities needed when updating the LaTeX2e sources. If you have a code suggestion please discuss it with the team first.

Pull requests in this repository are intended for LaTeX Team members only.

Internal housekeeping

Recently1, GitHub Actions learnt context github.ref_name whose

[...] value matches the branch or tag name shown on GitHub. For example, feature-branch-1.

This PR updates workflow file to use this context, hence drop the previous workaround using action frabert/replace-string-action.

Similar changes has been contributed to latex3 in latex3/latex3#1167.

Status of pull request

  • Feedback wanted
  • Under development
  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • ltnewsX.tex (and/or latexchanges.tex) updated

Footnotes

  1. The relevant GitHub doc is added by https://github.com/github/docs/commit/87806da34926498ab2ae0d01f8b125168e76ca8d in Nov 2021.

hence drop action `frabert/replace-string-action`
@zauguin zauguin merged commit acd4f13 into latex3:develop Feb 12, 2023
@muzimuzhi muzimuzhi deleted the ci-use-refname branch February 12, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants