Service & mock passed from component instead of adding in test.ts #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @lathonez,
I understand all your components and pages require clickerService and hence you set the service and its mock in test.ts itself.
As your blog is used as the reference to "How to add unit testing in ionic 2", those who are new to this might get confused by seeing the custom services and mocks added in the test.ts
The changes done in this PR allow the devs to pass the provider and mock from the component rather than setting it up in the test.ts, For some larger apps, it will keep the test.ts clean as well.
I think my changes might avoid this confusion. (May be I was the only one had that confusion).
Please check this and let me you know your thoughts.