Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Type casting to be explicit or throw warnings #15

Open
wulfsolter opened this issue Jan 16, 2018 · 1 comment
Open

[Feature] Type casting to be explicit or throw warnings #15

wulfsolter opened this issue Jan 16, 2018 · 1 comment
Assignees
@wulfsolter
Labels
enhancement

Comments

@wulfsolter
Copy link
Collaborator

No errors / warnings thrown when casting guest.lastVisit from remote text to local timestamp
@wulfsolter wulfsolter self-assigned this Jan 16, 2018
@lathonez
Copy link
Owner

Currently we're just using adding / missing properties to identify differences in the schema: https://github.com/lathonez/clone-row/blob/master/CloneRow.py#L426-L427

We also do explicit encoding checks here https://github.com/lathonez/clone-row/blob/master/CloneRow.py#L109

But we need to extend this to make sure the data types of columns match up too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wulfsolter wulfsolter

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wulfsolter @lathonez