Staging switch #587
Merged
Staging switch #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the relocateHandler service is to allow switching between the different deployments of arethusa (e.g. a main and a staging deployment). would be a bit nicer if this worked liked the exitHandler as an icon in the nav bar but I wanted to allow the possibility of supporting multiple locations and doing a dropdown on the click on the icon was more than I wanted to deal with for now. So the directive is just a basic list.
when merged to master this will be updated to use the sass variables $button-color and $button-color-hover
|
I think we can go ahead and deploy the changes (although I've not tested the changes, just read the source). |
|
thanks @Christof ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not the most beautiful or full-featured implementation, but I hope it will do for now. The idea is just to provide a quick way for users to access the staging environment to help us test and try out new features.
In a ideal world, I would have implemented this in a way that is a little more robust ...e .g. some better things to do would be:
But I don't have a lot of time to put into it right now and really need this deployed on Perseids ASAP.
As currently coded, we'll just have to have different versions of the perseids.json conf file in the deployment branch and in the master branch to have different configurations for the relocation handler for each.
@Christof @LFDM if either of you want to give me the nod to go ahead with it as-is over the weekend, I would very much appreciate it. If not, I will do without :) My plan is to merge and deploy on Monday 19 January first in this branch, and then master (deploying master to staging on Perseids)