Restyling event page & link to event list #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undermaken
requested changes
Jan 2, 2024
| { locale: 'it' } | ||
| ); | ||
|
|
||
| const EventAction = ({ |
There was a problem hiding this comment.
in order to avoid defining this component on every renderer, could it be moved outside EventActions as a standalone component (we could keep it in the same file)?
| [events] | ||
| ); | ||
| const nextEvents = useMemo( | ||
| () => sortEvents(filterComingEvents(events)), | ||
| [events] | ||
| ); | ||
|
|
||
| const hasMorePastEvents = events.length > MAX_PAST_EVENTS + nextEvents.length; |
There was a problem hiding this comment.
Maybe I didn't get the logic but I can't understand why nextEvents should be involved in this condition
Suggested change
| const hasMorePastEvents = events.length > MAX_PAST_EVENTS + nextEvents.length; | |
| const hasMorePastEvents = filterPastEvents(events).length > MAX_PAST_EVENTS; |
Am I losing something?
Undermaken
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Closes #36
What
Why
The user didn't have a way to enter the event page but manually write the URL
🖼 Screenshots/Recordings
Desktop new experience
screen-capture.webm
Phone new experience
screen-capture.2.webm
📝 To Do