Chart QA tasks #115
Merged
Chart QA tasks #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
force-pushed
the
fix/charts-blinking-loading
branch
from
1811cf1
to
4f6a882
Compare
geclos
reviewed
Mar 14, 2024
geclos
reviewed
Mar 14, 2024
geclos
reviewed
Mar 14, 2024
packages/client/svelte/src/lib/internal/ui/chart/_Wrapper.svelte
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
andresgutgon
force-pushed
the
fix/charts-blinking-loading
branch
6 times, most recently
from
f2d1b06
to
05f9301
Compare
andresgutgon
force-pushed
the
fix/charts-blinking-loading
branch
7 times, most recently
from
b4f0fbd
to
9f02668
Compare
🦋 Changeset detectedLatest commit: 7649a21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
andresgutgon
force-pushed
the
fix/charts-blinking-loading
branch
from
5a7fc58
to
715fb72
Compare
andresgutgon
commented
Mar 18, 2024
docs/snippets/charts/common.mdx
Outdated
There was a problem hiding this comment.
Mintlify allow DRY docs.Having charts config duplicated in each chart type was going me crazy. Sorry the ocd but I think this is much better now
andresgutgon
force-pushed
the
fix/charts-blinking-loading
branch
2 times, most recently
from
d248846
to
6e8c0c0
Compare
geclos
reviewed
Mar 19, 2024
geclos
reviewed
Mar 19, 2024
geclos
reviewed
Mar 19, 2024
| if (total === 0) { | ||
| return [row[0]].concat(rowData.map(() => 0)) | ||
| } | ||
| if (total === 0) return row.map((val) => { |
There was a problem hiding this comment.
nitpick: add brackets to this if
There was a problem hiding this comment.
You're very right in this one. I think we should for by ESLint the brackets
geclos
reviewed
Mar 19, 2024
geclos
reviewed
Mar 19, 2024
packages/client/svelte/src/lib/internal/ui/chart/_Wrapper.svelte
Outdated
Show resolved
Hide resolved
geclos
previously approved these changes
Mar 19, 2024
samulatitude
previously approved these changes
Mar 19, 2024
andresgutgon
force-pushed
the
fix/charts-blinking-loading
branch
from
6e8c0c0
to
97dca2f
Compare
- Add sort prop - Chart should have a title and description prop - Truncated X axis in mixed charts - Make the charts animate to the new state instead of flicker - Error display as in old latitude
andresgutgon
force-pushed
the
fix/charts-blinking-loading
branch
from
97dca2f
to
7649a21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve initial charts with after some initial QA
Issue
#143
TODO
<ChartLine />columns can be defined withoutchartType. By default arelinetype.sortprop and make clear that<LineChart />is optional to passchartTypenow