Table and AreaChart components for React #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0538c15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
csansoon
force-pushed
the
improved-theming-api-and-docs
branch
2 times, most recently
from
756fd69
to
a666591
Compare
geclos
approved these changes
May 2, 2024
csansoon
force-pushed
the
react-components
branch
5 times, most recently
from
e55b4ea
to
9ab566b
Compare
|
Don't bundle all the components in this PR, merge as you go so that we can begin QAing as we ship stuff. Also easier to review. |
csansoon
force-pushed
the
improved-theming-api-and-docs
branch
2 times, most recently
from
bc298f1
to
89aae27
Compare
csansoon
force-pushed
the
react-components
branch
2 times, most recently
from
705e701
to
db0ae52
Compare
csansoon
force-pushed
the
improved-theming-api-and-docs
branch
from
89aae27
to
47be7b5
Compare
andresgutgon
reviewed
May 3, 2024
andresgutgon
reviewed
May 3, 2024
andresgutgon
reviewed
May 3, 2024
|
|
||
| function QueryTable({ queryPath, params, download = false, tanstaskQueryOptions, ...rest }: Props) { | ||
| const { data, isLoading, error, download: downloadFn } = useQuery({ queryPath, params, tanstaskQueryOptions }) | ||
| const result = useMemo(() => new QueryResult(data), [data]) |
There was a problem hiding this comment.
Should useQuery return query result? I guess is something we're going to do everywhere
There was a problem hiding this comment.
Yeah I think it should...
There was a problem hiding this comment.
just wrap useQuery in another hook and use that to avoid repetition. We can explore a breaking change further down the line.
andresgutgon
reviewed
May 3, 2024
packages/client/react/src/lib/visualizations/raw/charts/AreaChart.tsx
Outdated
Show resolved
Hide resolved
andresgutgon
reviewed
May 3, 2024
@csansoon 🔴 1k lines should be enough for this PR |
csansoon
changed the base branch from
improved-theming-api-and-docs
to
basic-react-components
csansoon
force-pushed
the
basic-react-components
branch
from
21eec58
to
93b36a0
Compare
csansoon
force-pushed
the
basic-react-components
branch
5 times, most recently
from
66a0b79
to
ea94dca
Compare
csansoon
force-pushed
the
react-components
branch
10 times, most recently
from
d5617b6
to
e83100e
Compare
andresgutgon
approved these changes
May 7, 2024
geclos
reviewed
May 7, 2024
geclos
reviewed
May 7, 2024
geclos
reviewed
May 7, 2024
geclos
reviewed
May 7, 2024
geclos
reviewed
May 7, 2024
csansoon
force-pushed
the
react-components
branch
2 times, most recently
from
15f5fae
to
de462fa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added support for visualization components to react.
For this one, only Table and AreaChart were implemented. More visualizations will be implemented in a different PR.