Make source manager available to connectors. #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b045978 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
andresgutgon
force-pushed
the
feature/make-source-available-to-connectors
branch
from
95cd163
to
b4bdd2a
Compare
We need for future changes to be able to access and build queries from any connector when resolving the queries in a specific connector. To make our life easier we pass the source manager through the Source to the connector
andresgutgon
force-pushed
the
feature/make-source-available-to-connectors
branch
from
b4bdd2a
to
b045978
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
For future changes, we need access to
SourceManagerfrom the connectors. With this change we be able to dothis.source.managerinside the connectorsI removed 🔥
@latitude-data/base-connector🔥 and moved the code under@latitude-data/source-manager. I did this to avoid cyclic dependencies between all this code that is part of the same thing in the end.Issue ticket number and link
Related with #369
Checklist before requesting a review
SourceManagertoSourceSourceto connectors when are initialized.