Materialize storage driver package #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f847403 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
andresgutgon
force-pushed
the
feature/materialize-storage-driver-package
branch
4 times, most recently
from
4fdb2b0
to
0416f49
Compare
andresgutgon
force-pushed
the
feature/materialize-storage-driver-package
branch
3 times, most recently
from
4e63867
to
0f645b1
Compare
csansoon
reviewed
May 16, 2024
csansoon
reviewed
May 16, 2024
| @@ -26,6 +28,10 @@ describe('materializedRef function', async () => { | |||
| 'query.sql': sql, | |||
| }, | |||
| }, | |||
| [MATERIALIZE_QUERIES_DIR]: { | |||
| 'c669ba7574cadcfd9527e449feeb6a3fe8c23e23d0fef0893d3011c85ac88624.parquet': | |||
There was a problem hiding this comment.
save this custom id to a variable and use that instead
csansoon
reviewed
May 16, 2024
| @@ -41,7 +47,46 @@ describe('materializedRef function', async () => { | |||
| sql, | |||
| }, | |||
| }) | |||
| expect(compiled.sql).toBe('SELECT * FROM (SELECT * FROM users)') | |||
| expect(compiled.sql).toBe( | |||
| `SELECT * FROM (read_parquet('${MATERIALIZE_QUERIES_DIR}/c669ba7574cadcfd9527e449feeb6a3fe8c23e23d0fef0893d3011c85ac88624.parquet'))`, | |||
There was a problem hiding this comment.
I like to have hardcoded strings in the tests. This way I can't lie to myself by setting the wrong value in a variable. Now each time the result changes for any reason this test will fail. Which is what I want
andresgutgon
force-pushed
the
feature/materialize-storage-driver-package
branch
from
0f645b1
to
fa82bca
Compare
csansoon
reviewed
May 16, 2024
csansoon
approved these changes
May 16, 2024
When reading with DuckDB the parquet files from materialized queries we need a way of knowing where those queries are stored. We want to allow different ways of storing these parquet files. In this commit we start implementing the driver and the disk implementation that will be used almost always in development
andresgutgon
force-pushed
the
feature/materialize-storage-driver-package
branch
from
fa82bca
to
f847403
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When reading with DuckDB the parquet files from materialized queries we need a way of knowing where those queries are stored. We want to allow different ways of storing these parquet files. In this commit we start implementing the driver and the disk implementation that will be used almost always in development
Issue ticket number and link
#369
Checklist before requesting a review
apps/server