-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG-FIX] T Gate missng in RZ Gate definition #273
Conversation
So pytest did not pick this up as an error because the test classes were defined with the name |
@gwwatkin @alexnguyenn The test actions for pytest did not run properly for this! I stopped it after it ran for 20 minutes |
@isolatedinformation did you run |
And yes we need to fix this, when certain long snapshots don't match it seems to hang, but that is the whole point of snapshot tests, they check for regressions. @alexnguyenn can we set a timeout for a couple minutes? |
yeah i did run to update the snapshot and tests ran locally, it just did not on the actions |
@isolatedinformation I think you need to commit the changes to the snapshot files, I don't see any of them changed in the diff |
Codecov Report
@@ Coverage Diff @@
## dev #273 +/- ##
==========================================
+ Coverage 71.89% 71.98% +0.08%
==========================================
Files 31 31
Lines 2288 2288
==========================================
+ Hits 1645 1647 +2
+ Misses 643 641 -2
Continue to review full report at Codecov.
|
Issue Description
For both
Fraction(1,2)
andFraction(1,4)
, theto_clifford_plus_t()
method decomposes theRZ
rotation to the S gate for both the fractions, instead of decomposing to the S and T gates respectively. This PR fixes this :)How to Reproduce
Code Snippet
Error Output
Corrected Output (in this pr)