refactor(world): rename functionSelector to worldFunctionSelector (#2391

)
latticexyz · Mar 7, 2024 · 95f64c8 · 95f64c8
1 parent 3f5d33a
commit 95f64c8
Show file tree

Hide file tree

Showing 4 changed files with 46 additions and 33 deletions.
diff --git a/.changeset/warm-mails-cheat.md b/.changeset/warm-mails-cheat.md
@@ -0,0 +1,5 @@
+---
+"@latticexyz/world": patch
+---
+
+Renamed the `functionSelector` key in the `FunctionSelectors` table to `worldFunctionSelector`. This clarifies that `FunctionSelectors` is for world function selectors and can be used to generate the world ABI.
diff --git a/packages/cli/src/deploy/getFunctions.ts b/packages/cli/src/deploy/getFunctions.ts
@@ -39,7 +39,7 @@ export async function getFunctions({
         client,
         worldDeploy,
         table: worldTables.world_FunctionSelectors,
-        key: { functionSelector: selector },
+        key: { worldFunctionSelector: selector },
       });
       const { namespace, name } = hexToResource(systemId);
       // TODO: find away around undoing contract logic (https://github.com/latticexyz/mud/issues/1708)

diff --git a/packages/world/mud.config.ts b/packages/world/mud.config.ts
@@ -86,7 +86,7 @@ export default mudConfig({
     },
     FunctionSelectors: {
       keySchema: {
-        functionSelector: "bytes4",
+        worldFunctionSelector: "bytes4",
       },
       valueSchema: {
         systemId: "ResourceId",

diff --git a/packages/world/src/codegen/tables/FunctionSelectors.sol b/packages/world/src/codegen/tables/FunctionSelectors.sol